CODE.RNR

Learn, code, rock'n'roll

My first dotnet contribution

dotnet core github contribution open source SignedXml SHA

Recently I built a SOAP communication layer in dotnet core. I had to create a signed SAML request so I used SignedXml class to build the signature. References had to be added with SHA1 DigestMethod, and, as the documentation said, it was the default value of the property.

Then I got an error response from the server that the digest methods of references are invalid. After some debugging I realized that default value is SHA256 indeed. I made some research and found the commit that changed the default from SHA1 to SHA256. It was a bit surprising that the commit was pushed more than 2 years ago but nobody noticed the documentation inconsistency. So I read the contribution guideline, forked the docs repository and opened a pull request to fix it. And then it got reviewed and accepted. YAAAY!

It ain't much, but it's honest work